Use nyc instead of config.nyc in package.json
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| var config = require(path.resolve(this.cwd, './package.json')).config || {} | ||
| config = config.nyc || {} | ||
| var config | ||
| if (pkgPath) { |
There was a problem hiding this comment.
the constructor is getting pretty verbose at this point, mind moving the config logic into a private method, e.g., _loadConfig.
|
@jamestalmage looks good, just a couple comments. |
Fixes istanbuljs#131 This also uses `pkg-up` to locate the nearest `package.json` from `cwd`, and will move `cwd` to there. This allows you to invoke `nyc` from a subdirectory of your project and still have it behave as expected. This is something our caching mechanism already does. If it can't find a `package.json`, it just uses the original `cwd` option.
jamestalmage
force-pushed
the
use-top-level-nyc-config-in-pkg-json
branch
from
9a1bded to
434dd99
Compare
jamestalmage
added a commit
that referenced
this pull request
Jan 5, 2016
…-pkg-json Use `nyc` instead of `config.nyc` in package.json
| @@ -59,6 +60,24 @@ function NYC (opts) { | |||
| this.loadedMaps = null | |||
| } | |||
|
|
|||
| NYC.prototype._loadConfig = function (opts) { | |||
| var cwd = opts.cwd || process.env.NYC_CWD || process.cwd() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
This also uses
pkg-upto locate the nearestpackage.jsonfromcwd, and will movecwdto there. This allows you to invokenycfrom a subdirectory of your project and still have it behave as expected. This is something our caching mechanism already does. If it can't find apackage.json, it just uses the originalcwdoption.